Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Beta reset with lower work threshold #2186

Merged
merged 15 commits into from
Aug 5, 2019
Merged

Beta reset with lower work threshold #2186

merged 15 commits into from
Aug 5, 2019

Conversation

guilhermelawless
Copy link
Contributor

@guilhermelawless guilhermelawless commented Jul 30, 2019 •
edited
Loading

NOTE: This PR was not into master

  • 16x lower threshold + test
  • New genesis
  • Fix to allow missing rep_weights_beta.bin
  • Preconfigured representatives
  • Rebase onto master when all necessary commits are in

@zhyatt zhyatt requested review from wezrule and argakiig July 30, 2019 20:08
@zhyatt zhyatt added this to the V20.0 milestone Jul 30, 2019
Guilherme Lawless and others added 5 commits July 31, 2019 13:09
Accept multiplier in work_generate and work_validate (nanocurrency#2151)
fcb153f 
Add difficulty_optional_impl() and multiplier_optional_impl()
Multiplier overrides difficulty if both given
RPC version network label and identifier (nanocurrency#2184)
e07e75a 
* Add network label and identifier to RPC version.

Identifier is the genesis block hash as string.

* Fix unrelated shadowed local variable

* Format
Filter recent elections in update_active_difficulty (nanocurrency#2161)
1070476 
* Filter recent elections during active difficulty update

* Use network constant
@SergiySW
Compute work differently on Beta network (nanocurrency#1847)
2164a24 
* root = root ^ network number
* "work_generate" & "work_cancel" RPC should request XORed hash
@SergiySW
Use confirm_req by hash + root for upgraded peers (nanocurrency#2164)
2b1c89c 
* Use confirm_req by hash + root for upgraded peers with protocol version 17+
* Add send_confirm_req () function
* Simplify low reps weight requests burst condition
@cryptocode
Copy link
Contributor

For completeness, do we wanna update TEST (difficulty, multipliers) with a test for the beta threshold?

@guilhermelawless guilhermelawless mentioned this pull request Aug 1, 2019
Merged
@zhyatt zhyatt mentioned this pull request Aug 2, 2019
Closed
@argakiig argakiig merged this pull request into nanocurrency:beta_reset Aug 5, 2019
@guilhermelawless guilhermelawless deleted the beta-reset branch August 6, 2019 17:58
@guilhermelawless guilhermelawless restored the beta-reset branch August 6, 2019 18:50
@guilhermelawless guilhermelawless mentioned this pull request Aug 7, 2019
Merged
@zhyatt zhyatt removed this from the V20.0 milestone Aug 7, 2019
@guilhermelawless guilhermelawless deleted the beta-reset branch October 23, 2019 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@argakiig argakiig argakiig approved these changes

@wezrule wezrule Awaiting requested review from wezrule

Assignees

@guilhermelawless guilhermelawless

Labels
beta testing wanted enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@guilhermelawless @cryptocode @argakiig @zhyatt @SergiySW @wezrule