Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ASAN] Access node through a weak_ptr on distributed_work dtor #2554

Merged
merged 3 commits into from
Feb 12, 2020
Merged

[ASAN] Access node through a weak_ptr on distributed_work dtor #2554

merged 3 commits into from
Feb 12, 2020

Commits on Feb 12, 2020

  1. [ASAN] Access node through a weak_ptr on distributed_work dtor 

    Since there is nothing to force a distributed_work to get destroyed before the node stops, this is a safer way to access the node on the destructor. Fixes some ASAN issues.
    @guilhermelawless
    guilhermelawless committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    e99645f View commit details
    Browse the repository at this point in the history

  2. Add a comment explaining the use of node_w

    @guilhermelawless
    guilhermelawless committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    31dc15b View commit details
    Browse the repository at this point in the history

  3. [ASAN] fix issue in rpc.work_peer_many

    @guilhermelawless
    guilhermelawless committed Feb 12, 2020
    Configuration menu
    Copy the full SHA
    e5d4292 View commit details
    Browse the repository at this point in the history