Write database queue functions should be NoOps with RocksDB #2795
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
write_database_queue
is currently used by the block processor and confirmation height processor. It's purpose was to provide a way to know if something was holding the LMDB write transaction, so instead of being blocked it could continue doing work. This is not necessary with RocksDB as it doesn't have a global write lock, so these operations can be no-ops essentially.There were of course some tests relying on this behaviour to test somethings in the confirmation height processor. In those tests (any explicitly using
write_database_queue::contains ()
orwrite_database_queue::wait ()
) a new node flagforce_use_write_database_queue
can be set to true.