Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slow test fixes #2799

Merged
merged 5 commits into from
Jun 4, 2020
Merged

Slow test fixes #2799

merged 5 commits into from
Jun 4, 2020

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Jun 3, 2020

node_telemetry.under_load was failing. git bisected and found it was caused by #2782. It seems the increase in iterations on the test network (it's gone from 20 to 400!) was creating too much work. As the number of iterations is dependent on the block_processor_batch_max_time, I am changing default if using test network, which should scale with the process_confirmed_interval which is also changed from 500ms to 50ms on test network.

many_accounts_send_receive_self can time out after sequential voting PR, increase deadline timer.

Fixes a bug with popping from empty write_database_queue when stopping the node causing a hang.

@wezrule wezrule added the unit test Related to a new, changed or fixed unit test label Jun 3, 2020
@wezrule wezrule added this to the V21.0 milestone Jun 3, 2020
@wezrule wezrule self-assigned this Jun 3, 2020
@wezrule wezrule added the bug label Jun 4, 2020
Copy link
Contributor

@guilhermelawless guilhermelawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both tests now passing after adjusting the work difficulty, and no longer hanging on exit.

@wezrule wezrule merged commit 801f444 into nanocurrency:develop Jun 4, 2020
@wezrule wezrule deleted the slow_test_fixes branch June 4, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants