Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't crash using read-only CLI command with no ledger #2862

Merged
merged 2 commits into from Jul 28, 2020
Merged

Don't crash using read-only CLI command with no ledger #2862

merged 2 commits into from Jul 28, 2020

Conversation

wezrule
Copy link
Contributor

@wezrule wezrule commented Jul 28, 2020

It now correctly outputs "Genesis block not found. Make sure the node network ID is correct." which indicates that the ledger either doesn't exist or the data_path is set incorrectly, when using read-only CLI commands like --debug_block_count

@wezrule wezrule added the bug label Jul 28, 2020
@wezrule wezrule added this to the V22.0 milestone Jul 28, 2020
@wezrule wezrule self-assigned this Jul 28, 2020
@wezrule wezrule mentioned this pull request Jul 28, 2020
Closed
guilhermelawless
guilhermelawless previously approved these changes Jul 28, 2020
View reviewed changes
Copy link
Contributor

@guilhermelawless guilhermelawless left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prevents the crash, should we consider also noting on the message that the data_path may be incorrect or the database doesn't exist yet (must run daemon first)?

@wezrule wezrule merged commit a856799 into nanocurrency:develop Jul 28, 2020
@wezrule wezrule deleted the read_only_no_ledger_crash branch July 28, 2020 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guilhermelawless guilhermelawless guilhermelawless approved these changes

Assignees

@wezrule wezrule

Labels
bug
Projects
None yet
Milestone
V22.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wezrule @guilhermelawless