Constrained successor and destination block activation #2895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
guilhermelawless
commented
Aug 26, 2020
guilhermelawless
commented
- Activations only on active_confirmed_quorum or active_confirmation_height, which are the blocks/accounts of interest
- Only activate after cementing hardcoded bootstrap block count
- Limit activation of successor/destination elections based on roots size
guilhermelawless
added
quality improvements
SergiySW
approved these changes
Aug 27, 2020
clemahieu
approved these changes
Aug 27, 2020
| bool const was_active{ *election_status_type == nano::election_status_type::active_confirmed_quorum || *election_status_type == nano::election_status_type::active_confirmation_height }; | ||
|
|
||
| // Activations are only done if there is not a large amount of active elections, ensuring frontier confirmation takes place | ||
| auto const low_active_elections = [this] { return this->size () < nano::active_transactions::max_active_elections_frontier_insertion / 2; }; |
There was a problem hiding this comment.
This doesn't seem to need a lambda.
guilhermelawless
removed
the
blocker
guilhermelawless
added a commit
that referenced
this pull request
Sep 2, 2020
Adapted for V21.2 patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.