Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize unit tests: construct state blocks via builder #3188

Merged

Conversation

theohax
Copy link
Contributor

@theohax theohax commented Apr 15, 2021

Touched several of the core_test files.

@theohax theohax requested a review from clemahieu April 15, 2021 15:52
@clemahieu clemahieu dismissed a stale review via ec46286 April 20, 2021 11:47
clemahieu
clemahieu previously approved these changes Apr 20, 2021
@theohax theohax force-pushed the NANO-xxxx-modernize-tests-state-block-constructions branch from ec46286 to 2d9b60b Compare April 20, 2021 19:34
@clemahieu clemahieu merged commit 95064c7 into develop Apr 25, 2021
@zhyatt zhyatt added quality improvements This item indicates the need for or supplies changes that improve maintainability unit test Related to a new, changed or fixed unit test labels Apr 26, 2021
@zhyatt zhyatt added this to the V22.0 milestone Apr 26, 2021
@zhyatt zhyatt deleted the NANO-xxxx-modernize-tests-state-block-constructions branch September 30, 2021 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
quality improvements This item indicates the need for or supplies changes that improve maintainability unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants