Split election drop stats to be either overflow or expired #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redicate functions so identical logic can be checked in the condition_variable wait function and also inside the election_scheduler processing loop. This allows new predicates to be easily added and also eliminates risk of disjoin checks between the loop and the condition variable.
…scheduler::manual since the semantics of ::manual will be changed to not wait for vacancy before inserting.
… vacancy is not considered and elections are started for any blocks passed in. - Moves responsibility for trimming down election count from active_transaction in to election_scheduler. This is done so that more advanced filling/spilling can be done by the election scheduler in the future. - Erases from the active_transactions container by oldest transaction rather than by newest.
… vacancy is not considered and elections are started for any blocks passed in. - Moves responsibility for trimming down election count from active_transaction in to election_scheduler. This is done so that more advanced filling/spilling can be done by the election scheduler in the future. - Erases from the active_transactions container by oldest transaction rather than by newest.
theohax
reviewed
May 20, 2021
…entry points to .erase in future
SergiySW
reviewed
May 21, 2021
nano/node/active_transactions.cpp
Outdated
| @@ -330,6 +330,10 @@ void nano::active_transactions::request_confirm (nano::unique_lock<nano::mutex> | |||
| } | |||
|
|
|||
| // Locks active mutex, cleans up the election and erases it from the main container | |||
| if (!election_l->confirmed ()) | |||
clemahieu
force-pushed
the
election_scheduler_predicates
branch
2 times, most recently
from
0cf134b
to
e1d7025
Compare
MajorChump
commented
May 27, 2021
clemahieu
approved these changes
May 28, 2021
clemahieu
pushed a commit
that referenced
this pull request
Jun 11, 2021
At the moment it's not clear if elections are simply expiring after 5 minutes or being dropped due to the container overflowing. This should give us a better insight and allow us to monitor the situation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment it's not clear if elections are simply expiring after 5 minutes or being dropped due to the container overflowing. This should give us a better insight and allow us to monitor the situation.