Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Block store break up #3329

Merged
merged 9 commits into from Jun 14, 2021
Merged

Block store break up #3329

merged 9 commits into from Jun 14, 2021

Conversation

thsfs
Copy link
Contributor

@thsfs thsfs commented Jun 11, 2021

As part of the issue #3255:

  • Moves out version store functions to a version class.
  • Splits block_store class into two classes, store / block_store class. This last now just have block related functions.

@thsfs thsfs added this to the V23.0 milestone Jun 11, 2021
@thsfs thsfs self-assigned this Jun 11, 2021
thsfs
thsfs commented Jun 11, 2021
View reviewed changes
nano/secure/store_partial.hpp

protected:
nano::network_params network_params;
int const version_number{ 21 };
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because it was conflicting with version store, changed the variable name to version_number.

clemahieu
clemahieu previously approved these changes Jun 14, 2021
View reviewed changes
@thsfs thsfs merged commit 4d915c1 into develop Jun 14, 2021
@thsfs thsfs deleted the block_store_break_up branch June 14, 2021 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu approved these changes

@dsiganos dsiganos Awaiting requested review from dsiganos

@SergiySW SergiySW Awaiting requested review from SergiySW

@theohax theohax Awaiting requested review from theohax

Assignees

@thsfs thsfs

Labels
non-functional change
Projects
None yet
Milestone
V23.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thsfs @clemahieu @zhyatt