Fix half principal rep check #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
An account might be added that is not a half principal but might become a half principal later. So we should check for half principal every time.
The counting of half principals without tracking what is counted is unreliable. Fortunately, we only care about whether a half principal exists or not. So therefore convert the counter to a boolean so that the counter does not get used when it is wrong.
clemahieu
approved these changes
Jun 29, 2021
zhyatt
added
the
quality improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for half principal even if the account is a duplicate
An account might be added that is not a half principal but might become a half principal later. So we should check for half principal every time.
Convert half_principal counter to boolean
The counting of half principals without tracking what is counted is
unreliable. Fortunately, we only care about whether a half principal
exists or not. So therefore convert the counter to a boolean so that
the counter does not get used when it is wrong.