Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for unit test bulk.offline_send #3362

Merged

Commits on Jun 30, 2021

  1. Fix for unit test bulk.offline_send

    The test expected the ledger to be able to report a block as confirmed
    because the active transaction container was empty. But it has to allow
    for some time for the data/event to flow to the ledger.
    
    Converted an assert to an assert timely to allow for that propagation.
    
    This is the failure:
    [==========] Running 1 test from 1 test suite.
    [----------] Global test environment set-up.
    [----------] 1 test from bulk
    [ RUN      ] bulk.offline_send
    /home/ds/nano/branches/develop/nano-node/nano/core_test/bootstrap.cpp:1764: Failure
    Value of: node1->block_confirmed (send1->hash ())
      Actual: false
    Expected: true
    terminate called after throwing an instance of 'testing::internal::GoogleTestFailureException'
      what():  /home/ds/nano/branches/develop/nano-node/nano/core_test/bootstrap.cpp:1764: Failure
    Value of: node1->block_confirmed (send1->hash ())
      Actual: false
    Expected: true
    Aborted
    dsiganos committed Jun 30, 2021
    Configuration menu
    Copy the full SHA
    490c474 View commit details
    Browse the repository at this point in the history