Double unit test timeout in github CI #3363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes, the core_test and other tests, timeout when running in github CI. the tell tell sign of a timeout is the return code 124, which is returned by the timeout command. The CI computers are slow and as we add more and more tests we need to adjust this value to accommodate the slowness and the extra tests. I doubled the timeout so that there is less of a chance of failing due to timeout.
clemahieu
approved these changes
Jun 30, 2021
argakiig
approved these changes
Jun 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes, the core_test and other tests, timeout when running in github
CI. the tell tell sign of a timeout is the return code 124, which is
returned by the timeout command.
The CI computers are slow and as we add more and more tests we need to
adjust this value to accommodate the slowness and the extra tests.
I doubled the timeout so that there is less of a chance of failing
due to timeout.