Fix --rpcconfig cli option #3620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @fikumikudev, did you test that the option works? If it was never exercised it might be broken. |
|
Yes, I checked it and it seems to work. If there are any tests for '--config' option it would be possible to create analogous for '--rpcconfig', but I can't find anything. |
|
@fikumikudev we could do a "systest" as regression test for "--rpcconfig" |
cryptocode
approved these changes
Jan 6, 2022
dsiganos
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for --rpcconfig command line option. I noticed it was mentioned in documentation and the logic to process it was already implemented, however it was missing from option descriptions, so it was impossible to use it. This pull request fixes that.