Impove election result logging #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
changed the title
zhyatt
moved this from Pending testing evaluation
to Pending general testing
in V24.0DB1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, node logs result of every election, which makes log not only unreadable but also, in case of logging to terminal, uses surprisingly large amount of gpu to render the text alone. This PR adds a new log configuration option
election_resultthat users can use to configure this behavior. Additionally two new stat types are added that I found very useful to track election results without resorting to staring at text log,nano::stat::detail::election_confirmedandnano::stat::detail::election_not_confirmed.