Fix node.pruning_* unit tests
#3687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsfs
reviewed
Jan 24, 2022
| ASSERT_TRUE (node1.ledger.block_or_pruned_exists (nano::dev::genesis->hash ())); | ||
| ASSERT_TRUE (node1.ledger.block_or_pruned_exists (send1->hash ())); // true for pruned | ||
| ASSERT_TRUE (node1.ledger.block_or_pruned_exists (send1->hash ())); |
There was a problem hiding this comment.
I wouldn't remove this comment as it is there to facilitate debugging. If you have more info to add about the tests please do so.
There was a problem hiding this comment.
I did add some relevant comments at the beginning of the tests.
dsiganos
previously approved these changes
Jan 24, 2022
| @@ -4300,161 +4300,176 @@ TEST (rep_crawler, local) | |||
|
|
|||
| TEST (node, pruning_automatic) | |||
There was a problem hiding this comment.
Can we add a comment describing the intention of this unit test?
theohax
force-pushed
the
fix-node.pruning_xxx-unit-tests
branch
from
90826c4
to
9ecd690
Compare
dsiganos
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One more batch of fixes, put them in the same PR due to the tests being fairly similar to one another.
One of them (
node.pruning_age) just very recently was disabled in #3629, so linking the respective issue (#3641) to this PR.