Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket timeout tidyup #3704

Merged
merged 10 commits into from
Feb 3, 2022
Merged

Socket timeout tidyup #3704

merged 10 commits into from
Feb 3, 2022

Commits on Feb 2, 2022

  1. socket_timeout unit tests

    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    ad9f531 View commit details
    Browse the repository at this point in the history

  2. Rename socket::stop_timer to socket:set_last_completion 

    All stop timer does is to set a variable. It is a simply setter function.
It is confusing to call it stop_timer because it implies that it does
something more than just set a timestamp.
    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    ff04b78 View commit details
    Browse the repository at this point in the history

  3. Rename start_timer() to set_next_deadline()

    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    ed053fa View commit details
    Browse the repository at this point in the history

  4. Remove network constant socket_dev_idle_timeout 

    We do not need it.
    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    f137dd0 View commit details
    Browse the repository at this point in the history

  5. Rename update_last_receive_time() to set_last_receive_time() 

    To make it obvious it is setter function and to make it consistent with
other setter functions.
    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    aeb08e4 View commit details
    Browse the repository at this point in the history

  6. Minor code improvement - no functional change

    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    2f18d6c View commit details
    Browse the repository at this point in the history

  7. Rename the nano::socket concept of deadline to timeout 

    A deadline makes people imagine a fixed point in time, a timestamp.
However, socket::next_deadline is a timeout value and not a deadline.
It signifies the seconds of inactivity that would cause a socket timeout.

Renames:
set_next_deadline          -> set_default_timeout
set_next_deadline(timeout) -> set_timeout(timeout)
io_timeout                 -> default_timeout
timeout_set                -> set_default_timeout_value
next_deadline              -> timeout
    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5a70f24 View commit details
    Browse the repository at this point in the history

  8. Add some comments to nano::socket class

    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1bfcb73 View commit details
    Browse the repository at this point in the history

  9. Remove needless code

    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    799a070 View commit details
    Browse the repository at this point in the history

  10. Use guard ifs to make nano::socket::async_write more readable

    @dsiganos
    dsiganos committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    85cdaec View commit details
    Browse the repository at this point in the history