Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the nano::unchecked_info::confirmed member. #3719

Merged
merged 1 commit into from Feb 8, 2022

Conversation

clemahieu
Copy link
Contributor

@clemahieu clemahieu commented Feb 8, 2022

This was not serialized to the unchecked table. Additionally, the value was assigned from a comparison of retry counts so the naming of "confirmed" was confusing. Finally, its removal doesn't break any tests so it's not a tested branch of code.

…alized to the unchecked table. Additionally, the value was assigned from a comparison of retry counts so the naming of "confirmed" was confusing. Finally, its removing doesn't break any tests so it's not a tested branch of code.
@clemahieu clemahieu added this to the V24.0 milestone Feb 8, 2022
@theohax
Copy link
Contributor

theohax commented Feb 8, 2022

[ RUN      ] active_transactions.fork_replacement_tally
/Users/runner/work/nano-node/nano-node/nano/core_test/active_transactions.cpp:849: Failure
Expected equality of these values:
  max_blocks
    Which is: 10
  election->blocks ().size ()
    Which is: 1

Already on the to-fix list, so CI looks green-ish otherwise

@clemahieu clemahieu merged commit c6ff231 into nanocurrency:develop Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants