Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test election_scheduler.no_vacancy #3732

Merged
merged 1 commit into from Feb 15, 2022

Conversation

theohax
Copy link
Contributor

@theohax theohax commented Feb 10, 2022

There doesn't seem to be any already existing issue open for this unit test, so I cannot link anything to the PR.

I have to add a bunch of docs to the fixed unit test, but other than that it's totally reviewable.

@theohax theohax added bug unit test Related to a new, changed or fixed unit test labels Feb 10, 2022
@theohax theohax self-assigned this Feb 10, 2022
thsfs
thsfs previously approved these changes Feb 11, 2022
@theohax theohax force-pushed the fix-unit-test-election_scheduler.no_vacancy-TOPUSH branch from 8c5ba4d to 22332c0 Compare February 13, 2022 19:46
@theohax theohax merged commit eb8ad78 into develop Feb 15, 2022
@theohax theohax deleted the fix-unit-test-election_scheduler.no_vacancy-TOPUSH branch February 15, 2022 11:42
@zhyatt zhyatt added this to the V24.0 milestone Feb 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unit test Related to a new, changed or fixed unit test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants