Fix_fork_storm failure #3709 on node allocation and catch stalled vote/fork resolution errorrs in the test #3750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorted command line options output
Reduce number of nodes spawned for reasonable limits on most systems. C++ coding style and efficiency changes for iteration. Add diagnostic message streaming as an example.
clemahieu
approved these changes
Mar 14, 2022
|
Thanks for your help @Justin-Randall ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not make the test actually pass, it merely keeps if from failing over administrative interventions so developers can see what conditions the test reveals (either in the implementation or assumptions in the test itself).
Some additional diagnostics streaming to GTEST are included as a both a reference for better practices and to illustrate the failure condition.
Addressing issue #3709