Improve/fix test rpc.account_representative_set #3773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test wasn't testing properly that the RPC commands worked. It just checked that it got a reply. I improved the test to check that the representative really changed.
dsiganos
force-pushed
the
improve_test_rpc_account_representative_set
branch
from
adefd4d
to
6b71f58
Compare
zhyatt
approved these changes
Mar 30, 2022
|
I approved this as it matches the discussion we had about it, but another review of more of the code details is needed before merging. |
clemahieu
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test wasn't testing properly that the RPC commands worked.
It just checked that it got a reply.
I improved the test to check that the representative really changed.