Fix bootstrap serving threads regression #3898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Except i wonder if there is a risk of the bootstrap_server being destructed before the callback is run and causing dangling pointers. |
dsiganos
approved these changes
Sep 1, 2022
dsiganos
reviewed
Sep 1, 2022
| // TODO: Add completion callback to bulk pull server | ||
| auto bulk_pull_server = std::make_shared<nano::bulk_pull_server> (server, std::make_unique<nano::bulk_pull> (message)); | ||
| bulk_pull_server->send_next (); | ||
| server->node->bootstrap_workers.push_task ([server = server, message = message] () { |
There was a problem hiding this comment.
Should server be a weak_pointer which becomes strong inside the callback?
There was a problem hiding this comment.
Reference to bootstrap_server is only ever stored as weak_ptr in other places so we need to keep it non weak, otherwise it will get destroyed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression where bootstrap servers (bulk_pull_server, bulk_pull_account_server, bulk_push_server, frontier_req_server) are not using dedicated bootstrap threads when initializing. (I forgot to properly merge that part when rebasing bootstrap server fix). This PR fixes that.