Fix unit test active_transactions.fork_replacement_tally #3914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test had at least the following problems: 1. Issued blocks and not allowed the node time to process the blocks and start elections 2. It expected blocks to be processed in the order that they were created 3. Doing flood blood without clearing the publish filter 4. Not allowing time for blocks and votes to be processed in the background 5. Not allowing for the vote to the final winning block to arrive before the block
dsiganos
force-pushed
the
fix_unit_test_active_transactions_fork_replacement_tally
branch
from
8f9ded8
to
6a7ab23
Compare
pwojcikdev
approved these changes
Aug 27, 2022
|
I wonder if we should try and make the test process the reps in order so that the last 9 reps are always the ones in the election. Like the original author intended. Although, due to rep crawler lagging behind in time, syncing it might be tricky... |
dsiganos
deleted the
fix_unit_test_active_transactions_fork_replacement_tally
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test had at least the following problems:
the blocks and start elections