Fix for test election.quorum_minimum_update_weight_before_quorum_checks #3932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that there was a race condition between the rep crawler background thread and rep_crawler::response(). For be response to be processed as valid, a request must be marked in rep_crawler::active container.
dsiganos
force-pushed
the
fix_election_quorum_minimum_update_weight_before_quorum_checks
branch
from
29e64bd
to
bdf948a
Compare
pwojcikdev
previously approved these changes
Aug 31, 2022
dsiganos
force-pushed
the
fix_election_quorum_minimum_update_weight_before_quorum_checks
branch
from
36e7584
to
248eb87
Compare
pwojcikdev
approved these changes
Aug 31, 2022
dsiganos
deleted the
fix_election_quorum_minimum_update_weight_before_quorum_checks
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that there was a race condition between the rep crawler
background thread and rep_crawler::response(). For the response to be
processed as valid, a request must be marked in rep_crawler::active
container.