Fix MacOS compilation, add libsecure to target link libs for nano_lib #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsiganos
force-pushed
the
fix_macos_compilation_ipc_flatbuffers_test_client
branch
from
38fca9f
to
e494e4b
Compare
pwojcikdev
previously approved these changes
Sep 13, 2022
The problem appears to be that nano_lib uses libsecure but it is not listing it as a dependency. The ipc_flatbuffers_test_client does not list libsecure and the compilation was failing. The problem was only happening in MacOs Debug builds only. I assume that it was happening in Debug builds only because of an assert that used libsecure code. However, I do not understand why this problem was not appearing on linux.
dsiganos
force-pushed
the
fix_macos_compilation_ipc_flatbuffers_test_client
branch
from
e494e4b
to
256801f
Compare
dsiganos
deleted the
fix_macos_compilation_ipc_flatbuffers_test_client
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem appears to be that nano_lib uses libsecure but it is not listing it as a dependency. The ipc_flatbuffers_test_client does not list libsecure and the compilation was failing.
The problem was only happening in MacOs Debug builds only. I assume that it was happening in Debug builds only because of an assert that used libsecure code.
However, I do not understand why this problem was not appearing on linux.