Fix tests using election_scheduler::flush()
#3961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
prs/tests/election-scheduler
branch
from
0769646
to
1b2b026
Compare
pwojcikdev
changed the title
election_scheduler testselection_scheduler::flush()
clemahieu
previously approved these changes
Sep 27, 2022
|
@clemahieu I pushed one more commit fixing more test cases using the problematic flush |
|
Let's remove the scheduler flush from the test cases where we fixed it. |
|
@dsiganos Good point, those flush calls are not needed anymore. Already pushed a commit. |
dsiganos
reviewed
Sep 27, 2022
| @@ -47,7 +47,7 @@ TEST (election_scheduler, activate_one_flush) | |||
| system.nodes[0]->ledger.process (system.nodes[0]->store.tx_begin_write (), *send1); | |||
| system.nodes[0]->scheduler.activate (nano::dev::genesis_key.pub, system.nodes[0]->store.tx_begin_read ()); | |||
| system.nodes[0]->scheduler.flush (); | |||
There was a problem hiding this comment.
this schedule flush can go to
dsiganos
previously approved these changes
Sep 27, 2022
clemahieu
pushed a commit
to clemahieu/nano-node
that referenced
this pull request
Oct 1, 2022
* Fix tests using election_scheduler::flush * Fix more tests using `election_scheduler::flush` * Remove flush calls * One more flush removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small fix for a missing ASSERT_TIMELY