Stateless bootstrap server #3975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
messages.cpp
…ifferent traffic types
This will be useful for querying which account contains source gapping block
dsiganos
reviewed
Oct 17, 2022
nano/node/messages.cpp
Outdated
| debug_assert (header.extensions.to_ulong () > 0); // Block payload must have least `not_a_block` terminator | ||
| header.serialize (stream); | ||
| nano::write (stream, type); | ||
| nano::write (stream, id); |
There was a problem hiding this comment.
Endianness should be specified.
dsiganos
reviewed
Oct 17, 2022
dsiganos
reviewed
Oct 18, 2022
nano/node/messages.cpp
Outdated
| error = deserialize (stream); | ||
| if (!error) | ||
| { | ||
| update_header (); |
There was a problem hiding this comment.
Why is this updating the header? The header should either be right or wrong. It should not need updating/adjusting.
There was a problem hiding this comment.
Good catch, there is no reason to do that in there. Personally I would update the header during serialization, but that is the const method and I didn't want to suddenly refactor all message classes
This eliminates the need for allocating response messages
|
We discussed internally that adding account info query to the bootstrap server might be useful feature (even though it cannot be 100% trusted). The latest update added just that. @dsiganos |
clemahieu
approved these changes
Nov 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces stateless bootstrap server, a component that aims to replace the old bootstrap serving infrastructure. Old design relied on using dedicated tcp connections for bootstrapping, here I only utilize the realtime channels that are already established. Because of this, it is now possible to bootstrap from nodes that for any reason do not allow incoming connections (behind NAT, firewall rules). It will also reduce the number of needed sockets per peer. Lastly, it is also much faster because the requests are done asynchronously, so the effect of latency is minimized.