Introduce nano::test::start_election method #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many tests, we currently use the method node::block_confirm(), which uses block processor flush and is therefore broken. It is also terribly named. I introduce the method start_election with the aim of replacing node::block_confirm in unit tests. I converted a few unit tests to use this new function.
dsiganos
force-pushed
the
introduce_system_start_election
branch
from
b23fb23
to
dbeea3a
Compare
clemahieu
previously approved these changes
Feb 6, 2023
dsiganos
changed the title
dsiganos
force-pushed
the
introduce_system_start_election
branch
from
47e6ae2
to
c340b10
Compare
clemahieu
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many tests, we currently use the method node::block_confirm(), which uses scheduler flush and often block processor flush is called just before it too. The flush functions are unreliable and we plan to delete them.
I introduce the method start_election with the aim of replacing node::block_confirm in unit tests.
I converted a several unit tests to test it. I will do the rest too if there are no objections to this approach.