Decouple message deserializer from the TCP socket #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thsfs
requested review from
pwojcikdev and
clemahieu
and removed request for
pwojcikdev
thsfs
force-pushed
the
inproc_channel_with_message_desserializer
branch
from
d590edf
to
32c9108
Compare
clemahieu
reviewed
Feb 28, 2023
pwojcikdev
reviewed
Mar 1, 2023
pwojcikdev
previously approved these changes
Mar 1, 2023
clemahieu
approved these changes
Mar 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The message deserializer should not know about any socket class. If so, it would be bound to a specific channel implementation. Replaced this dependency by a function that reads and provides the required data. Modified the inproc channel to use the message deserializer instead of the old message parser, that will be removed.