work_pool: move stopping from destructor to stop function #4437
+152
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
reviewed
Feb 17, 2024
dsiganos
changed the title
pwojcikdev
reviewed
Feb 17, 2024
pwojcikdev
approved these changes
Feb 17, 2024
|
I missed a whole bunch of work_pool cases that are exercised when start node in non-daemon modes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The work_pool starts a number of threads and joins them in the destructor.
This is pattern we want to break. We want to have a separate stop stage before destruction.
This change makes work_pool follow the new pattern.