Bundle ledger transaction and write guard into a single object #4653
+231
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwojcikdev
force-pushed
the
transaction-write-queue-wrapper
branch
from
8a70ba7
to
6bee60f
Compare
clemahieu
approved these changes
Jun 22, 2024
gr0vity-dev
pushed a commit
to gr0vity-dev/nano-node
that referenced
this pull request
Jun 26, 2024
…urrency#4653) * Bundle transaction and write guard in a single object * Add tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that ledger write transactions and corresponding write queue guards are always acquired and released together. This in turn allows implementing
.refresh_if_needed ()function that handles both transaction and guard, which simplifies bounding of write transaction lifetimes.