Initial representative weights for bootstrapping. #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In the Python script, I'd recommend using |
|
@PlasmaPower I'm using that to zero-pad, so the resulting output is always 16/32 bytes. Python longs are variable size. |
|
@lukealonso can you confirm that this is mostly/totally contingent on #554? i.e. it doesn't make much sense to take this PR without that one? |
|
@androm3da I would say it's the other way around, it doesn't make much sense to take the other one without this one, but this one might make sense without the other one. |
androm3da
reviewed
Feb 1, 2018
ci/record_rep_weights.py
Outdated
| p = r.json() | ||
| block_height = max(0, int(p["count"]) - args.cutoff) | ||
|
|
||
| print("cutoff block height is %d" % block_height) |
There was a problem hiding this comment.
If you're going to use py3k style print, then I would recommend a from __future__ import print_function at the top. And if you do end up adding that, could you put a shebang with /usr/bin/env python too?
There was a problem hiding this comment.
This is just due to pure python ignorance, changed.
ci/record_rep_weights.py
Outdated
|
|
||
| reps.sort(key=lambda x: x["weight"], reverse=True) | ||
|
|
||
| of = open(args.output, "wb") |
There was a problem hiding this comment.
Please use with statements for robust file open/closure.
e.g.
with open(args.output, 'wb') as of:
lukealonso
force-pushed
the
initial_rep_weight
branch
from
abb6e28
to
b1033b7
Compare
lukealonso
force-pushed
the
initial_rep_weight
branch
from
b1033b7
to
721a948
Compare
|
Could we get a separate program (probably a Python script or part of the creation script) to read the rep weights file? I think that's important for transparency. |
|
@PlasmaPower they're dumped to the log every time the node starts, for transparency, but I'm also happy to add a script to print them without starting the node |
|
That should be good. In the future, I might make a script to compare it to your node's stake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow forks to be resolved during early bootstrap, this patch adds a small snapshot of the current rep weights, plus a block height at which to phase it out. This allows a bootstrapping client to use the live network's votes to resolve forks, at the risk of drift from those weight values. However, since the hardcoded weights stop being used after a certain block height, the drift can't be any worse than the (very severe) drift already present when bootstrapping.
Thanks to @PlasmaPower for the bit of cmake magic to embed the file in the executable.