Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max vote sequence comparison #964

Merged
merged 2 commits into from Sep 25, 2018
Merged

Fix max vote sequence comparison #964

merged 2 commits into from Sep 25, 2018

Conversation

PlasmaPower
Copy link
Contributor

Fixes #962. I'm not 100% sure about this so I'll have to think about it a bit. This shouldn't affect much.

@SergiySW
Copy link
Contributor

SergiySW commented Jul 20, 2018

Not cure about this part, but max_vote->sequesnce cannot be less than vote_a->sequence because of
https://github.com/nanocurrency/raiblocks/blob/master/rai/secure/blockstore.cpp#L1345

@rkeene rkeene added this to the V17.0 milestone Sep 11, 2018
@rkeene rkeene added the bug label Sep 11, 2018
@rkeene rkeene self-requested a review September 11, 2018 17:02
Copy link
Contributor

@rkeene rkeene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this change is right... Maybe...

@rkeene rkeene merged commit 1915a7b into master Sep 25, 2018
@rkeene rkeene mentioned this pull request Sep 25, 2018
@rkeene rkeene deleted the max-vote-sequence branch September 26, 2018 21:59
rkeene added a commit that referenced this pull request Sep 27, 2018
This was broken in #964
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants