Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow nanocurrency/nano-node#1981 #5

Merged
merged 10 commits into from Jul 12, 2019
Merged

Follow nanocurrency/nano-node#1981 #5

merged 10 commits into from Jul 12, 2019

Conversation

guilhermelawless
Copy link
Contributor

@guilhermelawless guilhermelawless commented May 6, 2019 •
edited

nanocurrency/nano-node#1981 and previous PRs.

@guilhermelawless guilhermelawless changed the title Multiplier in work_validate response following changes in nano_node Follow nanocurrency/nano-node#1981 May 17, 2019
@guilhermelawless
Copy link
Contributor Author

e537acf is to avoid panicking during operation, since println does not have any error handling. I was using it under a python subprocess with a pipe (other pipes would apply as well) and saw it break multiple times, crashing the server.

PlasmaPower
PlasmaPower reviewed May 17, 2019
View reviewed changes
Copy link
Contributor

@PlasmaPower PlasmaPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the node not accept multiplier as a parameter to work_generate?

src/main.rs Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
src/main.rs Outdated Show resolved Hide resolved
@guilhermelawless
Copy link
Contributor Author

multiplier is not accepted in the place of difficulty. Might be a possible extension to make it easier to use. Thank you for the review.

@icarusglider icarusglider merged commit 9cf9cd8 into nanocurrency:master Jul 12, 2019
@guilhermelawless guilhermelawless deleted the multiplier branch July 12, 2019 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PlasmaPower PlasmaPower PlasmaPower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@guilhermelawless @PlasmaPower @icarusglider