Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usage example #253

Merged
merged 3 commits into from
Nov 24, 2020
Merged

Fix usage example #253

merged 3 commits into from
Nov 24, 2020

Conversation

sphawk
Copy link
Contributor

@sphawk sphawk commented Nov 20, 2020

What does this PR do?

fix usage example

@lexicalunit
Copy link
Contributor

@sphawk thanks for the update! I took the liberty of running clang-format -i example/usage.cpp and adding the changes as a new commit: 686a084. This will resolve the CI/CD pipeline issue: https://travis-ci.org/github/nanodbc/nanodbc/jobs/744913747

Once we see all green in CI/CD we can get this merged.

sphawk
sphawk commented Nov 23, 2020
View reviewed changes
Copy link
Contributor Author

@sphawk sphawk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! I'll try it next time.
hmm. I think we need clang-format 5.0 now.

@lexicalunit
Copy link
Contributor

thanks! I'll try it next time.
hmm. I think we need clang-format 5.0 now.

Oops, my mistake. Thanks!

@lexicalunit lexicalunit merged commit 7ddfdec into nanodbc:master Nov 24, 2020
@mloskot mloskot mentioned this pull request Mar 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sphawk @lexicalunit