Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicode fix for column_datatype_name #263

Merged
merged 1 commit into from
Feb 5, 2021

Conversation

joesiltberg
Copy link
Contributor

@joesiltberg joesiltberg commented Feb 5, 2021

There was a missing NANODBC_FUNC around the call to SQLColAttribute,
also the wrong unit was used for the BufferLength sent to
SQLColAttribute (should be in bytes, not in characters).

What does this PR do?

Fixes a Unicode issue in column_datatype_name

What are related issues/pull requests?

#262

Tasklist

  • Review
  • All CI builds and checks have passed

Environment

  • DBMS name/version: MS SQL Server
  • ODBC connection string: Driver={ODBC Driver 17 for SQL Server};Server=tcp:xxx.database.windows.net,1433;Database=xxx;Uid=xxx;Pwd=xxx;Encrypt=yes;TrustServerCertificate=no;Connection Timeout=30;
  • OS and Compiler: Debian Buster, gcc 7.5.0

There was a missing NANODBC_FUNC around the call to SQLColAttribute,
also the wrong unit was used for the BufferLength sent to
SQLColAttribute (should be in bytes, not in characters).

Fixes nanodbc#262
Copy link
Member

@mloskot mloskot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@mloskot mloskot added this to the 2.14+ milestone Feb 5, 2021
@mloskot mloskot merged commit 550d0ca into nanodbc:master Feb 5, 2021
@mloskot mloskot changed the title Unicode fix for column_datatype_name. Unicode fix for column_datatype_name Feb 5, 2021
@mloskot mloskot mentioned this pull request Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants