Take fix from r-dbi to allow correct retrieval of datetimeoffset #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloskot
requested changes
Dec 23, 2021
There was a problem hiding this comment.
Thank you very much for the patch.
It looks good, just an indentation nitpick.
Could you also add to the PR description references to related r-dbi PR(s) ?
Is it this one r-dbi/odbc#219 perhaps?
Comment on lines
+881
to
+891
| auto t = result.get<nanodbc::string>(0); | ||
| // the result is this NANODBC_TEXT("2006-12-30 13:45:12.3450000 -08:00"); | ||
| REQUIRE(t.size() >= 27); // frac of seconds is server and system dependend | ||
| REQUIRE(t.substr(0, 23) == NANODBC_TEXT("2006-12-30 13:45:12.345")); | ||
| auto it = t.rbegin(); | ||
| REQUIRE(*it++ == '0'); | ||
| REQUIRE(*it++ == '0'); | ||
| REQUIRE(*it++ == ':'); | ||
| REQUIRE(*it++ == '8'); | ||
| REQUIRE(*it++ == '0'); | ||
| REQUIRE(*it++ == '-'); |
There was a problem hiding this comment.
The indentation here needs some correction here.
There was a problem hiding this comment.
Yep, looks like a mix of tabs and spaces.
There was a problem hiding this comment.
Interestingly, the ling CI job seems fine
There was a problem hiding this comment.
Hrm, linter still passing after rebase. Weird.
This was referenced Dec 23, 2021
lexicalunit
requested changes
Dec 23, 2021
3 tasks
|
Updated the style by running |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will change the API behaviour of datetimeoffset.
It is no longer possible to get those columns via the timestamp class.
Since the timestamp class has no notion of UTC offset, allowing the datetimeoffset as a unparsed strings seems more reasonable.