Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@nanoexpress/middleware-schemator): esModule import on cjs #23

Merged
merged 3 commits into from Jun 8, 2021

Conversation

game5413
Copy link
Contributor

@game5413 game5413 commented Jun 8, 2021

Pull Request

Is you/your team sponsoring this project

  • Yes
  • No

If your team sponsoring this project, please attach here your team lead or who purchased license GitHub login

What you changed

  • Code changes
  • Tests changed
  • Typo fixes

If you change code, tests should be passed

Note

  • Your every change to feature/code should be documented
  • 馃摑 Documentation fixes should be filled here
  • nanoexpress fixes should be filled here

game5413 and others added 2 commits June 8, 2021 15:48
@game5413
Copy link
Contributor Author

game5413 commented Jun 8, 2021

Is the format commit message for linting fixes was correct ? i'm using past commit message on branch master, or just using current format message ?

@dalisoft
Copy link
Member

dalisoft commented Jun 8, 2021

I'm not sure your code works properly, so i'll test as soon as i get some time and let your know or merge

@dalisoft
Copy link
Member

dalisoft commented Jun 8, 2021

As currently I don鈥檛 have time to test, so let鈥檚 merge. Anyway you tested and for you it鈥檚 more need than me

@dalisoft dalisoft merged commit c4ab50b into nanoexpress:master Jun 8, 2021
@github-actions
Copy link

github-actions bot commented Jun 8, 2021

馃帀 This PR is included in version @nanoexpress/middleware-schemator-v3.0.6 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants