Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for M5Core2 in Graphics Primitives #302

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jsuutari
Copy link
Contributor

Description

Added support for M5Core2 in Graphics Primitives Sample

Motivation and Context

  • Helps users with M5Core2 to run Primitives sample with minimal changes

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a sample)
  • Bug fix (fixes an issue with a current sample)
  • New Sample (adds a new sample)
  • Config and build (change in the configuration and build system, has no impact on code or features)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@Ellerbach Ellerbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the proposition but this sample should work for all kind of MCU. So if you want to create a specific version for M5Stack, I'm fine. In that case, create another project, reuse all the cs file (by reference in the project, not by copy/paste), and adjust as well the README and category.txt so we're clear that it's a specific sample for M5Stack

@josesimoes
Copy link
Member

@Ellerbach this seems to be stalled... do we want to merge it anyways and rework it later?

@Ellerbach
Copy link
Member

do we want to merge it anyways and rework it later?

No merge for this one. Like we did for others, it's ok to create 2 projects so they work directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants