Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nbgv to 3.5.103 #719

Merged
merged 1 commit into from May 9, 2022
Merged

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented May 9, 2022

Description

⚠️ OK to revert adding the targets and Directory.Build.props when updating to a future release of nbgv ⚠️

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Add dummy targets and buid props.
@josesimoes josesimoes added VS2019 Specific to VS2019 VS2022 Specific to VS2022 labels May 9, 2022
@josesimoes josesimoes merged commit 787609d into nanoframework:develop May 9, 2022
@josesimoes josesimoes deleted the update-nbgv branch May 9, 2022 14:42
josesimoes added a commit to josesimoes/nf-Visual-Studio-extension that referenced this pull request May 12, 2022
- Definitive update after nanoframework#719 without requiring the fake targets.
@josesimoes josesimoes mentioned this pull request May 12, 2022
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: dependencies VS2019 Specific to VS2019 VS2022 Specific to VS2022
Projects
None yet
2 participants