Draft Feature: Add SQLite #2381
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josesimoes
reviewed
Jun 27, 2022
|
|
||
| struct Library_nf_system_data_sqlite_System_Data_Sqlite_ResultSet | ||
| { | ||
| static const int FIELD__<RowCount>k__BackingField = 1; |
There was a problem hiding this comment.
@networkfusion you need to implement the backing fields for these properties.
There was a problem hiding this comment.
I am quite out of my depth... 😱
There was a problem hiding this comment.
Oh. Let me help : this is on the C# code. You need to add fields to the class to be the backing fields. We can't have auto-properties in nano when the code is used in native.
There was a problem hiding this comment.
lol... I will have to revisit, as I am starting to count sheep 🤣
...ChibiOS/ST_STM32F769I_DISCOVERY/nanoCLR/nanoFramework.Graphics/DSI_To_Display_Video_Mode.cpp
Outdated
Show resolved
Hide resolved
(Needs turning off before merge).
(although still probably in the wrong place!)
networkfusion
force-pushed
the
add-sqlite
branch
from
01dc184
to
f97da57
Compare
Ellerbach
reviewed
Oct 13, 2022
| shell.c | ||
| sqlite3.c | ||
| sqlite3.h | ||
| sqlite3.ext.h |
There was a problem hiding this comment.
why all those files when the cmake only uses 1?
josesimoes
force-pushed
the
main
branch
2 times, most recently
from
a02925b
to
ee07b5a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
A long time feature request is to add SQLite support. This PR adds the skeleton for such a request and is backed up by the managed layer in https://github.com/networkfusion/nanoFramework.System.Data.SQLite
It still requires a lot more work before it is ready for integration, but hoping there is community contributions towards it!
How Has This Been Tested?
Screenshots
Types of changes
Checklist