Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly offset managed SPI bus ID to native for ESP32C3 and S3 #2915

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

CoryCharlton
Copy link
Member

Description

  • Properly offset managed SPI bus ID to native for C3 and S3 ESP32 devices.

Motivation and Context

So the SD card works on S3 devices.

How Has This Been Tested?

On device.

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

@josesimoes josesimoes added Platform: ESP32 Everything related specifically with ESP32 platform Series: ESP32C3 Series: ESP32S3 labels Apr 23, 2024
Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please just add that comment with the explanation for this as I've requested? On the lines that are missing it.

@CoryCharlton
Copy link
Member Author

Can you please just add that comment with the explanation for this as I've requested? On the lines that are missing it.

Sorry forgot about that. It's updated now.

Copy link
Member

@josesimoes josesimoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Thanks.

@josesimoes josesimoes changed the title Properly offset managed SPI bus ID to native for C3 and S3 ESP32 devices Properly offset managed SPI bus ID to native for ESP32C3 and S3 Apr 24, 2024
@josesimoes josesimoes merged commit 96ce46a into nanoframework:main Apr 24, 2024
13 checks passed
@CoryCharlton CoryCharlton deleted the fix_s3_sd_card branch April 24, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform: ESP32 Everything related specifically with ESP32 platform Series: ESP32C3 Series: ESP32S3 Type: bug
Projects
None yet
3 participants