Add Generic display to ESP32_S3_BLE

[AdrianSoundy]

Description

Adds generic display driver to ESP32_S3_BLE build so there is a display firmware for both Quad and Octal spiram boards

Motivation and Context

• Resolves Add generic display to target ESP32_S3_BLE Home#1487

How Has This Been Tested?

Checked booting and memory use locally

Types of changes

• Improvement (non-breaking change that improves a feature, code or algorithm)
• Bug fix (non-breaking change which fixes an issue with code or algorithm)
• New feature (non-breaking change which adds functionality to code)
• Breaking change (fix or feature that would cause existing functionality to change)
• Config and build (change in the configuration and build system, has no impact on code or features)
• Dev Containers (changes related with Dev Containers, has no impact on code or features)
• Dependencies (update dependencies and changes associated, has no impact on code or features)
• Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

• My code follows the code style of this project (only if there are changes in source code).
• My changes require an update to the documentation (there are changes that require the docs website to be updated).
• I have updated the documentation accordingly (the changes require an update on the docs in this repo).
• I have read the CONTRIBUTING document.
• I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

• New Features
  • Added support for graphics display and touch panel interfaces on ESP32.
  • Configured SPI RAM allocation for improved performance.

[coderabbitai]

Walkthrough

The changes in CMakePresets.json for the ESP32 target primarily introduce new API features for graphics and touch panel interfaces, and configure SPI RAM allocation for the IDF. These enhancements aim to expand the device's capabilities, particularly in handling graphics displays and touch panels, while addressing memory allocation requirements.

Changes

File	Change Summary
targets/ESP32/CMakePresets.json	Added new API features for graphics (API_nanoFramework.Graphics) and touch panels (XPT2046). Configured SPI RAM allocation for IDF (ESP32_SPIRAM_FOR_IDF_ALLOCATION).

Sequence Diagram(s) (Beta)

No sequence diagrams are generated as the changes are primarily configuration updates and do not introduce new control flows.

Assessment against linked issues

Objective (Issue #)	Addressed	Explanation
Ensure compatibility with Azure IoT Central (1487)	❓	The changes do not directly address the System.Net.Sockets.SocketException issue mentioned. They focus on graphics and touch panel configurations.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between b2a469d and e122283.

Files selected for processing (1)

• targets/ESP32/CMakePresets.json (1 hunks)

Additional comments not posted (1)

targets/ESP32/CMakePresets.json (1)

372-378: Configuration additions for ESP32_S3_BLE are aligned with PR objectives.

The additions of API_nanoFramework.Graphics, GRAPHICS_DISPLAY, TOUCHPANEL_DEVICE, GRAPHICS_DISPLAY_INTERFACE, TOUCHPANEL_INTERFACE, and ESP32_SPIRAM_FOR_IDF_ALLOCATION are consistent with the PR's goal to enhance graphical capabilities and touch interface support. Ensure that these settings are tested across different environments to confirm stability and performance.