fixed bug in derived quantities

nanograv · Dec 8, 2023 · 7896a55 · 7896a55
1 parent 4d07835
commit 7896a55
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/CHANGELOG-unreleased.md b/CHANGELOG-unreleased.md
@@ -14,4 +14,5 @@ the released changes.
 - Documentation: Added `convert_parfile` to list of command-line tools in RTD
 ### Fixed
 - Fixed runtime data README 
+- Fixed `derived_params` when OMDOT has 0 uncertainty
 ### Removed
diff --git a/src/pint/fitter.py b/src/pint/fitter.py
@@ -72,7 +72,12 @@
 import pint
 import pint.utils
 import pint.derived_quantities
-from pint.models.parameter import AngleParameter, boolParameter, strParameter
+from pint.models.parameter import (
+    AngleParameter,
+    boolParameter,
+    strParameter,
+    funcParameter,
+)
 from pint.pint_matrix import (
     CorrelationMatrix,
     CovarianceMatrix,
@@ -624,7 +629,11 @@ def get_derived_params(self):
                 and self.model.OMDOT.value != 0.0
             ):
                 omdot = self.model.OMDOT.quantity
-                omdot_err = self.model.OMDOT.uncertainty
+                omdot_err = (
+                    self.model.OMDOT.uncertainty
+                    if self.model.OMDOT.uncertainty is not None
+                    else 0 * self.model.OMDOT.quantity.unit
+                )
                 ecc = (
                     ecc.n * u.dimensionless_unscaled
                     if ell1