Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model conversion ICRS <-> ECL works if PM uncertainties are not set #1598

Merged
merged 2 commits into from Jun 22, 2023

Conversation

dlakaplan
Copy link
Contributor

Previously if the PM uncertainties were None, model.as_ICRS() would fail. This fixes that.

@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (d5ea5e8) 68.12% compared to head (c89724a) 68.13%.

❗ Current head c89724a differs from pull request most recent head 0ecdba9. Consider uploading reports for the commit 0ecdba9 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1598      +/-   ##
==========================================
+ Coverage   68.12%   68.13%   +0.01%     
==========================================
  Files          98       98              
  Lines       22621    22619       -2     
  Branches     3883     3883              
==========================================
+ Hits        15410    15411       +1     
+ Misses       6261     6260       -1     
+ Partials      950      948       -2     
Impacted Files Coverage Δ
src/pint/models/astrometry.py 92.20% <ø> (ø)

... and 6 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@dlakaplan dlakaplan added bug fix Bug fixing pull request awaiting review This PR needs someone to review it so it can be merged labels Jun 22, 2023
@paulray paulray merged commit 03b3bb7 into nanograv:master Jun 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review This PR needs someone to review it so it can be merged bug fix Bug fixing pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants