Type hints in pint.toa and get_model & get_model_and_toas functions
#1755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhisrkckl
changed the title
pint.toapint.toa and pint.models
|
I don't know if we want to follow #1756 and define custom types. Like |
|
Yes I'll use those definitions once that pr is merged. |
abhisrkckl
changed the title
pint.toa and pint.modelspint.toa and get_model & get_model_and_toas functions
abhisrkckl
added
the
awaiting review
dlakaplan
reviewed
May 15, 2024
dlakaplan
reviewed
May 15, 2024
dlakaplan
reviewed
May 15, 2024
|
I think there are still a few functions that need a return type of |
|
Looks good. Seems like you fixed those missing hints. All set to merge? |
|
Yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1709