Adding Gibbs sampling code to ENTERPRISE EXTENSIONS #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Gibbs Method (Bayes Power) code for single pulsar analyses.
Testing the Gibbs Method code
The gibbs sampling code is added alongside its test. This method performs the Gibbs sampling of single-pulsar analyses.
|
Do I need to use "black" for the linting issues? |
Yes, black should fix the linting |
|
Looking at the code, it seems you've included more than just the Gibbs sampler. As fas as I can see, this PR should only included enterprise_extensions/altpol/altmodel.py | 137 ++++++++++++++++++++++++++++++
enterprise_extensions/altpol/altorfs.py | 45 ++++++++++
enterprise_extensions/altpol/altutils.py | 232 +++++++++++++++++++++++++++++++++++++++++++++++++++
enterprise_extensions/blocks.py | 5 +-
enterprise_extensions/frequentist/optimal_statistic.py | 30 ++++---
enterprise_extensions/gibbs_sampling/gibbs.py | 468 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
tests/test_gibbs.py | 55 ++++++++++++Could you split off the alternative polarization utilities and blocks updates in a different branch? If you work on multiple features, it's often more maintainable to develop them in separate git branches, and then file a PR from one of those into the main repo. Then you can keep stuff that isn't ready out of the PR |
Linting problems removed by "black". Altpol utils removed (they were included by accident!)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The updated Gibbs sampling code is added alongside its test. This method performs the Gibbs sampling of single-pulsar analyses.