Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve gen_lib_sam API #59

Closed
lzkelley opened this issue May 6, 2023 · 2 comments
Closed

Improve gen_lib_sam API #59

lzkelley opened this issue May 6, 2023 · 2 comments
Assignees
@lzkelley
Labels
cleanup Maintainance-related cleanup issue

Comments

@lzkelley
Copy link
Member

lzkelley commented May 6, 2023

(1) combine SS and 'normal' functions/interfaces to use options instead of separate functions

(2) move all reusable materials from gen_lib_sam.py to librarian.py

(3) add option whether or not to perform fits (consider just moving fits to a post-processing step, instead of concurrent with lib gen)
@lzkelley lzkelley added the cleanup Maintainance-related cleanup issue label May 6, 2023
@lzkelley lzkelley self-assigned this May 6, 2023
@lzkelley lzkelley mentioned this issue Jun 9, 2023
Closed
@lzkelley
Copy link
Member Author

lzkelley commented Jun 9, 2023

Also cleanup how the parameter spaces are handled, i.e. #48

@lzkelley
Copy link
Member Author

This is almost fully completed with the new librarian module, and specifically the librarian.gen_lib interface. Some cleanup of command-line arguments, and streamlining how they are handled, is still possible. Leave that for a future issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzkelley lzkelley

Labels
cleanup Maintainance-related cleanup issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lzkelley