Dev evolving #110
Merged
Dev evolving #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add redz=redz as argument to dmstar_dmbh in line 358 for use in evolving version of mmbulge function
Add except ValueError statement to mbh_from_mbulge (within MMBulge_Redshift) on line 848 to catch another instance where redz doesn't need to be reshaped
Changed line 846 to make the try/except statement more broad except TypeError: to except:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Two small updates to enable usage of evolving MMBulge. Not sure if they got accidentally overwritten or if they somehow never made it into the last PR...
Todos
Notable points that this PR has either accomplished or will accomplish.
Questions
Status