-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Content of <Helmet> should always be trusted #59
Comments
Oh, I’m sorry. #44 This PR maybe causes this issue 🙇. I want to fix this issue, but I’m worried about under what conditions to trust(= not escape text node). I think that if text node is descendants of |
Thanks for your help. I'm already about to fix it :) I think everything under This behavior should be clear in the docs as well. Check https://github.com/nanojsx/nano/compare/fix-helmet-ssr |
Oh! Nice 👍 Looks good, Thanks 🙏 Should we describe this behavior in the |
👍 |
See #57
(FYI,
withStyles()
uses<Helmet />
under the hood.)<Helmet />
nornoscript
,script
orstyle
by default. #61The text was updated successfully, but these errors were encountered: