Fix protocol error when sending mqtt v4 msg to mqtt v5 client #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* FIX [mqtt/transport] fix PINGRESP
JaylinYu
force-pushed
the
jaylin/mqtt5
branch
from
d299b8f
to
4d4b36c
Compare
|
just fixed the confliction, Please review, but it need to work with another PR in nanomq |
wanghaEMQ
reviewed
Feb 21, 2022
| * @return uint32_t | ||
| */ | ||
| uint32_t | ||
| nni_mqtt_get_property_len(nni_msg *m) |
There was a problem hiding this comment.
This function looks incomplete
wanghaEMQ
approved these changes
Feb 21, 2022
This was referenced Feb 11, 2023
This was referenced Mar 23, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.